abroekhuis commented on a change in pull request #172: Refactor TcpAdmin and add interfacing for VectorIoSerialisation URL: https://github.com/apache/celix/pull/172#discussion_r401802801
########## File path: bundles/pubsub/pubsub_spi/include/pubsub_utils_url.h ########## @@ -0,0 +1,55 @@ +/* Review comment: Ah ok, I get it, since it is used by the other Admins as well I guess this makes sense. My first impression was that since it is in the spi, it would be a requirement for other admins as well. Thinking out loud now, does it make sense to move these kind of functions to another directory? Technically it is not a SPI. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
