rbulter commented on a change in pull request #192: Fixed merge problems wrt
scope usage.
URL: https://github.com/apache/celix/pull/192#discussion_r408165480
##########
File path: bundles/pubsub/pubsub_spi/src/pubsub_endpoint.c
##########
@@ -159,12 +161,11 @@ celix_properties_t*
pubsubEndpoint_createFromPublisherTrackerInfo(bundle_context
char* topic = NULL;
char* scopeFromFilter = NULL;
pubsub_getPubSubInfoFromFilter(filter, &scopeFromFilter, &topic);
- const char *scope = scopeFromFilter == NULL ? "default" : scopeFromFilter;
+ const char *scope = scopeFromFilter;
struct retrieve_topic_properties_data data;
data.props = NULL;
data.isPublisher = true;
- data.scope = scope;
Review comment:
i use data.scope = scope, i have no issues with the examples
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
