Ok, I'll take a look. Afaik, scope of variables is couple to a cmakefile. But I'll try if I can fix thix.
-- Met vriendelijke groet, Alexander Broekhuis On 24 apr. 2020 09:25 +0200, GitBox <[email protected]>, wrote: > > pnoltes commented on a change in pull request #202: > URL: https://github.com/apache/celix/pull/202#discussion_r414354776 > > > > ########## > File path: CMakeLists.txt > ########## > @@ -41,7 +41,7 @@ ELSE () > set(CMAKE_C_FLAGS "-D_GNU_SOURCE -std=gnu99 -fPIC ${CMAKE_C_FLAGS}") > set(CMAKE_CXX_FLAGS "-std=c++11 -fno-rtti ${CMAKE_CXX_FLAGS}") > set(CMAKE_C_FLAGS "-Wall -Werror ${CMAKE_C_FLAGS}") > - set(CMAKE_CXX_FLAGS "-Wall -Wextra -Weffc++ ${CMAKE_CXX_FLAGS}") > > Review comment: > Personally I find effc++ one of the most important flags. Not always nice too > see the warning after committing for OSX (clang), but almost always very > useful warnings. > > In other words I would like to keep effc++ > > > > > ---------------------------------------------------------------- > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > [email protected] > >
