Oipo commented on a change in pull request #228:
URL: https://github.com/apache/celix/pull/228#discussion_r421990977
##########
File path: cmake/cmake_celix/BundlePackaging.cmake
##########
@@ -107,7 +107,7 @@ Optional arguments are:
- GROUP: The group the bundle is part of. This will be used as Bundle-Group
manifest entry. Default this is empty (no group).
- VERSION: The bundle version. This will be used for the Bundle-Version
manifest entry. In combination with SOURCES the version will also be used to
set the activator library target property VERSION and SOVERSION.
For SOVERSION only the major part is used. Expected scheme is
"<major>.<minor>.<path>". Default version is "0.0.0"
-- FILENAME: The filename of the bundle file. Default is
<bundle_target_name>.zip.
+- FILENAME: The filename of the bundle file, without extension. Default is
<bundle_target_name>.zip.
Review comment:
`Default is <bundle_target_name>.zip.`, but the .zip part is removed
now, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
