Adding +1 from me and closing the vote
On Thu, May 14, 2020 at 8:39 PM Alexander Broekhuis <a.broekh...@gmail.com> wrote: > > Ah yes, of course. I knew that ;). Thanks for the reminder! > > Op do 14 mei 2020 om 20:03 schreef Pepijn Noltes <pepijnnol...@gmail.com>: > > > Vote is on a commit id. After the vote passes a tag is created [1]. > > > > [1] https://celix.apache.org/contributing/releasing.html > > > > On Thu, May 14, 2020 at 7:45 PM Alexander Broekhuis > > <a.broekh...@gmail.com> wrote: > > > > > > One notice, there is no tag yet in git... > > > > > > Op do 14 mei 2020 om 19:44 schreef Alexander Broekhuis < > > > a.broekh...@gmail.com>: > > > > > > > +1 > > > > > > > > Don't see anything strange. Archive has correct hash, builds as > > expected. > > > > > > > > Op do 14 mei 2020 om 09:22 schreef Pepijn Noltes < > > pepijnnol...@gmail.com>: > > > > > > > >> Hi Roy, > > > >> > > > >> Thanks for voting > > > >> > > > >> @Rest: Please look at the release and vote. We need al teast 3 +1 > > > >> (binding) votes. > > > >> We should have enough committers to get through this smoothly. > > > >> > > > >> Greetings, > > > >> Pepijn > > > >> > > > >> On Thu, May 14, 2020 at 9:15 AM Roy Lenferink <rlenfer...@apache.org> > > > >> wrote: > > > >> > > > > >> > Thanks for fixing. > > > >> > > > > >> > Here my +1 (binding) on the release. > > > >> > > > > >> > Roy > > > >> > > > > >> > On 2020/05/11 17:40:46, Pepijn Noltes <pepijnnol...@gmail.com> > > wrote: > > > >> > > Hi Roy, > > > >> > > > > > >> > > Thanks for looking into this. > > > >> > > I updated the checksums. > > > >> > > > > > >> > > Greetings, > > > >> > > Pepijn > > > >> > > > > > >> > > On Mon, May 11, 2020 at 2:44 PM Roy Lenferink < > > rlenfer...@apache.org> > > > >> wrote: > > > >> > > > > > > >> > > > Hi, > > > >> > > > > > > >> > > > -1 (binding) but +1 (binding) as soon as you fix the hash issue. > > > >> > > > > > > >> > > > See https://infra.apache.org/release-distribution#sigs-and-sums > > > >> for the policy on checksums. > > > >> > > > > > > >> > > > Short summary: if you remove the md5 checksum and update the > > .sha > > > >> checksum to become .sha512 > > > >> > > > then my -1 (binding) will become a +1 (binding). > > > >> > > > > > > >> > > > - Roy > > > >> > > > > > > >> > > > (I updated the process on the website already) > > > >> > > > > > > >> > > > On 2020/05/10 19:16:16, Pepijn Noltes <pepijnnol...@gmail.com> > > > >> wrote: > > > >> > > > > This is the release vote for Apache Celix, version 2.2.1. > > > >> > > > > > > > >> > > > > It fixes the following issues: > > > >> > > > > - Fixes etcdlib CMake setup to that etcdlib can be build as a > > > >> separate project > > > >> > > > > > > > >> > > > > Source files: > > > >> > > > > https://dist.apache.org/repos/dist/dev/celix/celix-2.2.1/ > > > >> > > > > > > > >> > > > > The commit ID to be voted upon: > > > >> > > > > b618e6aa1df05c91b2d7ba8a6768d023cafdce36 > > > >> > > > > > > > >> > > > > > > > >> > > https://github.com/apache/celix/tree/b618e6aa1df05c91b2d7ba8a6768d023cafdce36 > > > >> > > > > > > > >> > > > > Celix's keys can be found at: > > > >> > > > > https://dist.apache.org/repos/dist/dev/celix/KEYS > > > >> > > > > > > > >> > > > > Information for voting on a release can be found at: > > > >> > > > > http://www.apache.org/dev/release.html#approving-a-release > > > >> > > > > > > > >> > > > > Please vote to approve this release: > > > >> > > > > > > > >> > > > > [ ] +1 Approve the release > > > >> > > > > [ ] -1 Disapprove the release (please provide specific > > comments) > > > >> > > > > > > > >> > > > > Note that an Apache release needs to be a Majority Approval > > > >> (requires > > > >> > > > > at-least 3 binding +1 votes and more +1 votes than -1 votes). > > > >> > > > > > > > >> > > > > If this release is approved I will promote it to an official > > > >> release > > > >> > > > > (e.g. move from dist/dev to dist/release and tagging the > > release > > > >> in git) > > > >> > > > > > > > >> > > > > This vote will be open for at least 72 hours. > > > >> > > > > > > > >> > > > > > >> > > > > > > > > > > > > -- > > > > Met vriendelijke groet, > > > > > > > > Alexander Broekhuis > > > > > > > > > > > > > -- > > > Met vriendelijke groet, > > > > > > Alexander Broekhuis > > > > > -- > Met vriendelijke groet, > > Alexander Broekhuis
