pnoltes commented on a change in pull request #253:
URL: https://github.com/apache/celix/pull/253#discussion_r439967855
##########
File path: libs/framework/src/celix_log.c
##########
@@ -26,6 +26,7 @@
#include "celix_log.h"
#include "celix_threads.h"
#include "celix_array_list.h"
+#include "memstream/open_memstream.h"
Review comment:
memstream was not part of OSX, that why we have an optional memstream
(Apache License) implementation in lib utils.
In recent OSX version this is not needed any more. Its cheched with a cmake
function:
check_function_exists(open_memstream OPEN_MEMSTREAM_EXISTS)
But this included should only be used on system which do not have an
open_memstream implementation, else it part of stdio.h.
I am not sure why this is not failing on Linux/Ubuntu builds ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
