pnoltes commented on a change in pull request #265:
URL: https://github.com/apache/celix/pull/265#discussion_r448823326
##########
File path: libs/framework/src/dm_dependency_manager_impl.c
##########
@@ -173,7 +174,8 @@ static void celix_dm_getInfosCallback(void *handle, const
celix_bundle_t *bnd) {
celix_array_list_t *
celix_dependencyManager_createInfos(celix_dependency_manager_t *manager) {
celix_array_list_t *infos = celix_arrayList_create();
- celix_bundleContext_useBundles(manager->ctx, infos,
celix_dm_getInfosCallback);
+ celix_framework_t* fw = celix_bundleContext_getFramework(manager->ctx);
Review comment:
yes the dm is part of the framework. This removed the need for
additional linking (per bundle) and more importantly the needed special linking
instructions with the "-Wl,--no-as-needed" for linux and for osx something
else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
