Oipo commented on a change in pull request #267:
URL: https://github.com/apache/celix/pull/267#discussion_r452162377
##########
File path: bundles/pubsub/pubsub_topology_manager/src/pubsub_topology_manager.c
##########
@@ -79,6 +79,7 @@ celix_status_t
pubsub_topologyManager_create(celix_bundle_context_t *context, ce
manager->loghelper = logHelper;
manager->verbose = celix_bundleContext_getPropertyAsBool(context,
PUBSUB_TOPOLOGY_MANAGER_VERBOSE_KEY, PUBSUB_TOPOLOGY_MANAGER_DEFAULT_VERBOSE);
+ manager->handlingThreadSleepTime =
celix_bundleContext_getPropertyAsLong(context,
PUBSUB_TOPOLOGY_MANAGER_HANDLING_THREAD_SLEEPTIME_SECONDS_KEY,
PSTM_PSA_HANDLING_DEFAULT_SLEEPTIME_IN_SECONDS);
Review comment:
I don't think the overhead of calling
`celix_bundleContext_getPropertyAsLong()` matters much, but that's the only
reason I can think of not wanting to do it inside of the loop.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
