pnoltes commented on a change in pull request #292:
URL: https://github.com/apache/celix/pull/292#discussion_r523746033
##########
File path: bundles/pubsub/pubsub_admin_zmq/src/psa_activator.c
##########
@@ -62,7 +62,7 @@ int psa_zmq_start(psa_zmq_activator_t *act,
celix_bundle_context_t *ctx) {
//track serializers
if (status == CELIX_SUCCESS) {
celix_service_tracking_options_t opts =
CELIX_EMPTY_SERVICE_TRACKING_OPTIONS;
- opts.filter.serviceName = PUBSUB_SERIALIZER_SERVICE_NAME;
+ opts.filter.serviceName = PUBSUB_MESSAGE_SERIALIZATION_SERVICE_NAME;
Review comment:
The marker interface was not intended for performance issues, but
intended to prevent no available serialiser issues.
So if json serializing is supported, but at the moment no actual serialiser
is available, the marker interface is present to indicate json serialization is
supported.
But maybe this is over designed ... so yeah let's discuss this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
