Oipo commented on a change in pull request #279:
URL: https://github.com/apache/celix/pull/279#discussion_r544260711
##########
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_sender.c
##########
@@ -343,18 +335,25 @@ const char
*pubsub_tcpTopicSender_topic(pubsub_tcp_topic_sender_t *sender) {
}
const char *pubsub_tcpTopicSender_url(pubsub_tcp_topic_sender_t *sender) {
- return sender->url;
+ if (sender->isPassive) {
+ return pubsub_tcpHandler_get_connection_url(sender->socketHandler);
+ } else {
+ return sender->url;
+ }
}
-
bool pubsub_tcpTopicSender_isStatic(pubsub_tcp_topic_sender_t *sender) {
return sender->isStatic;
}
-void pubsub_tcpTopicSender_connectTo(pubsub_tcp_topic_sender_t *sender, const
celix_properties_t *endpoint) {
+bool pubsub_tcpTopicSender_isPassive(pubsub_tcp_topic_sender_t *sender) {
+ return sender->isPassive;
+}
+
+void pubsub_tcpTopicSender_connectTo(pubsub_tcp_topic_sender_t *sender
__attribute__((unused)), const celix_properties_t *endpoint
__attribute__((unused))) {
Review comment:
Please remove unused function.
##########
File path: bundles/pubsub/pubsub_admin_tcp/src/pubsub_tcp_topic_sender.c
##########
@@ -343,18 +335,25 @@ const char
*pubsub_tcpTopicSender_topic(pubsub_tcp_topic_sender_t *sender) {
}
const char *pubsub_tcpTopicSender_url(pubsub_tcp_topic_sender_t *sender) {
- return sender->url;
+ if (sender->isPassive) {
+ return pubsub_tcpHandler_get_connection_url(sender->socketHandler);
+ } else {
+ return sender->url;
+ }
}
-
bool pubsub_tcpTopicSender_isStatic(pubsub_tcp_topic_sender_t *sender) {
return sender->isStatic;
}
-void pubsub_tcpTopicSender_connectTo(pubsub_tcp_topic_sender_t *sender, const
celix_properties_t *endpoint) {
+bool pubsub_tcpTopicSender_isPassive(pubsub_tcp_topic_sender_t *sender) {
+ return sender->isPassive;
+}
+
+void pubsub_tcpTopicSender_connectTo(pubsub_tcp_topic_sender_t *sender
__attribute__((unused)), const celix_properties_t *endpoint
__attribute__((unused))) {
//TODO subscriber count -> topic info
}
-void pubsub_tcpTopicSender_disconnectFrom(pubsub_tcp_topic_sender_t *sender,
const celix_properties_t *endpoint) {
+void pubsub_tcpTopicSender_disconnectFrom(pubsub_tcp_topic_sender_t *sender
__attribute__((unused)), const celix_properties_t *endpoint
__attribute__((unused))) {
Review comment:
Please remove unused function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
