pnoltes commented on a change in pull request #293:
URL: https://github.com/apache/celix/pull/293#discussion_r544413751
##########
File path: libs/framework/include/celix/dm/ServiceDependency.h
##########
@@ -59,20 +61,20 @@ namespace celix { namespace dm {
}
}
public:
- BaseServiceDependency(bool v) : valid{v} {
+ BaseServiceDependency(celix_dm_component_t* c, bool v) : cCmp{c},
valid{v} {
if (this->valid) {
this->cServiceDep = celix_dmServiceDependency_create();
//NOTE using suspend as default strategy
celix_dmServiceDependency_setStrategy(this->cServiceDep,
DM_SERVICE_DEPENDENCY_STRATEGY_SUSPEND);
}
}
- virtual ~BaseServiceDependency() = default;
+ virtual ~BaseServiceDependency() noexcept;
Review comment:
:+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
