Oipo commented on a change in pull request #318:
URL: https://github.com/apache/celix/pull/318#discussion_r577079233
##########
File path: libs/promises/api/celix/impl/SharedPromiseState.h
##########
@@ -106,9 +107,11 @@ namespace celix::impl {
std::shared_ptr<celix::IExecutor> getExecutor() const;
+ std::shared_ptr<celix::IScheduledExecutor> getScheduledExecutor()
const;
Review comment:
This function (and coincidentally the `getExecutor` function that was
already there) are good examples of being marked with `[[nodiscard]]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
