Oipo commented on a change in pull request #310:
URL: https://github.com/apache/celix/pull/310#discussion_r580069489
##########
File path: libs/framework/include/celix_bundle_activator.h
##########
@@ -139,75 +139,6 @@ celix_status_t celix_bundleActivator_destroy(void
*userData, celix_bundle_contex
#ifdef __cplusplus
}
-
-
-/**
- * This macro generates the required bundle activator functions for C++.
- * This can be used to more type safe bundle activator entries.
- *
- * The macro will create the following bundle activator functions:
- * - bundleActivator_create which allocates a pointer to the provided type.
- * - bundleActivator_start/stop which will call the respectively provided
typed start/stop functions.
- * - bundleActivator_destroy will free the allocated for the provided type.
- *
- * @param type The activator type (e.g. 'ShellActivator'). A type which should
have a constructor with a single arugment of std::shared_ptr<DependencyManager>.
- */
-#define CELIX_GEN_CXX_BUNDLE_ACTIVATOR(actType)
\
Review comment:
Oh, I must've missed the moving of the define. I thought it was deleted
entirely.
##########
File path: libs/framework/include/celix_bundle_activator.h
##########
@@ -139,75 +139,6 @@ celix_status_t celix_bundleActivator_destroy(void
*userData, celix_bundle_contex
#ifdef __cplusplus
}
-
-
-/**
- * This macro generates the required bundle activator functions for C++.
- * This can be used to more type safe bundle activator entries.
- *
- * The macro will create the following bundle activator functions:
- * - bundleActivator_create which allocates a pointer to the provided type.
- * - bundleActivator_start/stop which will call the respectively provided
typed start/stop functions.
- * - bundleActivator_destroy will free the allocated for the provided type.
- *
- * @param type The activator type (e.g. 'ShellActivator'). A type which should
have a constructor with a single arugment of std::shared_ptr<DependencyManager>.
- */
-#define CELIX_GEN_CXX_BUNDLE_ACTIVATOR(actType)
\
Review comment:
Oh, I must've missed the moving of the define/macro. I thought it was
deleted entirely.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
