pnoltes commented on issue #352: URL: https://github.com/apache/celix/issues/352#issuecomment-889862814
unlocking and directly locking is indeed strange and for me a code smell. That said, this is civetweb code. Celix embeds civetweb for remote service and the http admin: https://github.com/apache/celix/tree/0729c4dfaa6b45f436e41f13ebe71960c746d109/bundles/remote_services/civetweb/src https://github.com/apache/celix/tree/0729c4dfaa6b45f436e41f13ebe71960c746d109/bundles/http_admin/civetweb Ideally the remote service admin should use the http admin instead of reallying directly on civetweb, but because remote service predates the http admin bundle this has not been done. Celix does notmaintain the civetweb code. The civetweb project can be found at https://github.com/civetweb/civetweb Looking at the code at civetweb, the approach has changed, but the unlock then lock idiom is still there: https://github.com/civetweb/civetweb/blob/master/src/civetweb.c#L4785-L4807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
