[GitHub] [celix] pnoltes commented on a change in pull request #367: Use etcd header index instead of modified index for ETCD GET call

[GitBox]

pnoltes commented on a change in pull request #367:
URL: https://github.com/apache/celix/pull/367#discussion_r710349773



##########
File path: libs/etcdlib/src/etcd.c
##########
@@ -165,11 +166,11 @@ int etcdlib_get(etcdlib_t *etcdlib, const char* key, 
char** value, int* modified
 
                if (js_root != NULL) {
                        js_node = json_object_get(js_root, ETCD_JSON_NODE);
+            js_index = json_object_get(js_root, ETCD_JSON_INDEX);

Review comment:
       nitpick. misaligned indent

##########
File path: libs/etcdlib/src/etcd.c
##########
@@ -143,6 +143,7 @@ int etcd_get(const char* key, char** value, int* 
modifiedIndex) {
 int etcdlib_get(etcdlib_t *etcdlib, const char* key, char** value, int* 
modifiedIndex) {
        json_t *js_root = NULL;
        json_t *js_node = NULL;
+    json_t *js_index = NULL;

Review comment:
       nitpick. misaligned indent




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org