rlenferink commented on a change in pull request #372:
URL: https://github.com/apache/celix/pull/372#discussion_r725209890
##########
File path:
bundles/cxx_remote_services/integration/src/TestExportImportRemoteServiceFactory.cc
##########
@@ -323,6 +389,47 @@ class ExportedCalculator final {
factory = fac;
}
+ int init() {
+ return CELIX_SUCCESS;
+ }
+
+ int start() {
+ resultStream = calculator->result();
+ resultStream->forEach([weakSvc =
std::weak_ptr<ICalculator>{calculator}, weakPub =
std::weak_ptr<pubsub_publisher>{publisher}](const double& event){
+ auto pub = weakPub.lock();
+ auto svc = weakSvc.lock();
+ if (pub && svc) {
+ thread_local unsigned int eventMsgId = 0;
+ if (eventMsgId == 0) {
+ pub->localMsgTypeIdForMsgType(pub->handle,
"Calculator$result$Event", &eventMsgId);
+ }
+
+ auto* metaProps = celix_properties_create();
+ celix_properties_set(metaProps, "invoke.id",
std::to_string(0).c_str());
+ Calculator$result$Event wireEvent;
+ wireEvent.optionalReturnValue.buf = (double *)
malloc(sizeof(*wireEvent.optionalReturnValue.buf));
+ wireEvent.optionalReturnValue.len = 1;
+ wireEvent.optionalReturnValue.cap = 1;
+ wireEvent.optionalReturnValue.buf[0] = event;
+ wireEvent.optionalError = nullptr;
+ pub->send(pub->handle, eventMsgId, &wireEvent, metaProps);
+ free(wireEvent.optionalReturnValue.buf);
+ } else {
+ //TODO error handling
Review comment:
A TODO for this PR or should we create an issue?
##########
File path:
bundles/cxx_remote_services/integration/src/TestExportImportRemoteServiceFactory.cc
##########
@@ -29,7 +31,7 @@
#include "pubsub/publisher.h"
#include "pubsub/subscriber.h"
-constexpr auto INVOKE_TIMEOUT = std::chrono::seconds{10};
+constexpr auto INVOKE_TIMEOUT = std::chrono::seconds{5}; //TODO make
configurable
Review comment:
A TODO for this PR or should we create an issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
