pnoltes opened a new pull request #382: URL: https://github.com/apache/celix/pull/382
This PR updates the std::string arguments in the (C++17) methods to std::string_view and if applicable also update the std::string return arguments to std::string_view. This make it possible to use std::string_view objects as input and as result use constructions like: `constexpr std::string_view MY_CONSTANT = "value";` for constants. Currently string_view arguments are assumed to refer to null-terminated strings. This is essential the same as with handling `const char*` arguments. Technically string_view objects can refer to not null-terminated strings and this is also detectable (using string_view::size() and looking for the '\0'), but expensive. IMO this is not really necessary. Mainly, because we also assume `const char*` arguments are null-terminated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
