PengZheng commented on a change in pull request #399: URL: https://github.com/apache/celix/pull/399#discussion_r816450268
########## File path: libs/framework/include/service_registration.h ########## @@ -39,9 +39,6 @@ FRAMEWORK_EXPORT celix_status_t serviceRegistration_unregister(service_registrat FRAMEWORK_EXPORT celix_status_t serviceRegistration_getProperties(service_registration_t *registration, celix_properties_t **properties); -FRAMEWORK_EXPORT celix_status_t -serviceRegistration_setProperties(service_registration_t *registration, celix_properties_t *properties); Review comment: The 3.0 move will be fantastic! At a moment I suddenly realized only headers included in celix_api.h should be considered public. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org