PengZheng commented on a change in pull request #401:
URL: https://github.com/apache/celix/pull/401#discussion_r827573365



##########
File path: CMakeLists.txt
##########
@@ -116,9 +148,11 @@ if (CMAKE_BUILD_TYPE STREQUAL "Debug")
 endif()
 
 # Set version for the framework package/release
-set(CELIX_MAJOR "2")
-set(CELIX_MINOR "2")
-set(CELIX_MICRO "1")
+if (NOT DEFINED CELIX_MAJOR)

Review comment:
       if not defined externally (by conan)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to