pnoltes commented on pull request #401: URL: https://github.com/apache/celix/pull/401#issuecomment-1074392182
The overall changes to the cmake files LGTM. Nice improvement on the subproject usage. I also tried out the conan build environment and I think I got it. The commands I am using are: ``` conan install . --output-folder cmake-build-release --build=missing cd cmake-build-release cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo .. make -j ``` So conan builds the dependencies and does a setup of the a cmake build directory preconfigured for the conan dependencies. The default subproject build options are IMO also ok. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
