PengZheng commented on a change in pull request #407:
URL: https://github.com/apache/celix/pull/407#discussion_r835857341
##########
File path:
bundles/remote_services/discovery_common/src/endpoint_discovery_server.c
##########
@@ -163,11 +163,13 @@ celix_status_t endpointDiscoveryServer_create(discovery_t
*discovery,
char newPort[10];
do {
+ char listeningPorts[50]={0};
const char *options[] = {
- "listening_ports", port,
+ "listening_ports", listeningPorts,
"num_threads", DEFAULT_SERVER_THREADS,
NULL
};
+ snprintf(listeningPorts,sizeof(listeningPorts),"%s:%s",(*server)->ip,
port);
Review comment:
It should be made clear that why 50 bytes space is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
