PengZheng commented on a change in pull request #408:
URL: https://github.com/apache/celix/pull/408#discussion_r841221545
##########
File path: conanfile.py
##########
@@ -226,10 +227,14 @@ def _configure_cmake(self):
self._cmake.definitions[opt.upper()] = self.options.get_safe(opt,
False)
self._cmake.definitions["CMAKE_PROJECT_Celix_INCLUDE"] =
os.path.join(self.build_folder, "conan_paths.cmake")
# the following is workaround for
https://github.com/conan-io/conan/issues/7192
- self._cmake.definitions["CMAKE_EXE_LINKER_FLAGS"] =
"-Wl,--unresolved-symbols=ignore-in-shared-libs"
+ if self.settings.os == "Linux":
+ self._cmake.definitions["CMAKE_EXE_LINKER_FLAGS"] =
"-Wl,--unresolved-symbols=ignore-in-shared-libs"
self.output.info(self._cmake.definitions)
- v = tools.Version(self.version)
- self._cmake.configure(defs={'CELIX_MAJOR': v.major, 'CELIX_MINOR':
v.minor, 'CELIX_MICRO': v.patch})
+ if self.version is None:
Review comment:
version is a must when invoking `conan create`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
