PengZheng commented on code in PR #437:
URL: https://github.com/apache/celix/pull/437#discussion_r965440477
##########
bundles/remote_services/remote_service_admin_shm_v2/shm_pool/src/shm_cache.c:
##########
@@ -240,7 +240,7 @@ static void * shmCache_WatcherThread(void *data) {
for (int i = 0; i < size; ++i) {
shm_cache_block_t *shmBlock = celix_arrayList_get(evictedBlocks,
i);
celix_longHashMap_remove(shmCache->shmCacheBlocks,
shmBlock->shmId);
- fprintf(stdout, "Shm cache: Shm(%d) has been closed, colse its
cache.\n", shmBlock->shmId);
+ fprintf(stdout, "Shm cache: Shm(%d) has been closed, close its
cache.\n", shmBlock->shmId);
Review Comment:
New code should not use raw printf.
Without access to bundle/framework context, we can still use logging macro,
which defaults to no output. Or shall we use syslog instead of printf? I
suggest a discussion with @pnoltes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
