PengZheng commented on code in PR #447:
URL: https://github.com/apache/celix/pull/447#discussion_r1033500149
##########
libs/framework/include/celix/TrackerBuilders.h:
##########
@@ -42,9 +42,9 @@ namespace celix {
//NOTE private to prevent move so that a build() call cannot be
forgotten
ServiceTrackerBuilder(ServiceTrackerBuilder&&) noexcept = default;
public:
- explicit ServiceTrackerBuilder(std::shared_ptr<celix_bundle_context_t>
_cCtx, std::string_view _name) :
+ explicit ServiceTrackerBuilder(std::shared_ptr<celix_bundle_context_t>
_cCtx, std::string _name) :
Review Comment:
Taking Item 41 into account, passing `_name` by value is indeed a good
choice. Resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
