pnoltes opened a new pull request, #451:
URL: https://github.com/apache/celix/pull/451
This PR splits up the CELIX_CXX into a CELIX_CXX14 and CELIX_CXX17 option.
The default C++ language is also updated to C++14 to ensure libs/bundles
using C++ are default complaint with C++14.
Also:
- Fix an uncaught exception coverity issue (CID 236044) by making the
promise::resolve promise::fail implementation not thrown an exception if the
promise is already done. Note that throwing an exception is part of the OSGi
specification, but IMO throwing exception for a lib that should make multi
threading programming more easy is not a good design. For the Celix
implementation the tryFail and tryResolve can be used to atomically try to
fail/resolve a promise and check whether it was already done.
- Remove unused/dead C++ RSA Topology Manager code. If this is needed, the
code can be reintroduced using git history.
-Refactor the C++ RSA integration test. Originally the promise was tested
first, but I think there was a race condition that this could fail if the
pubsub connection was not fully established yet. The remote promise call in now
retried a couple of times. This should fix #397
- Fix cv-qualifiers issue with template deduction for the Promise class.
- Made C++ RSA default on. IMO the C++ RSA is proven to be stable enough
(in my day-time job).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
