PengZheng commented on code in PR #459:
URL: https://github.com/apache/celix/pull/459#discussion_r1059617105


##########
bundles/deployment_admin/src/deployment_admin.c:
##########
@@ -212,6 +214,8 @@ static celix_status_t 
deploymentAdmin_performRequest(deployment_admin_pt admin,
                 status = CELIX_BUNDLE_EXCEPTION;
                 fw_log(celix_frameworkLogger_globalLogger(), 
CELIX_LOG_LEVEL_ERROR, "Error sending auditlog, got curl error code %d", res);
             }
+    } else {
+        fw_log(celix_frameworkLogger_globalLogger(), CELIX_LOG_LEVEL_ERROR, 
"Error creating send url for audit log url", admin->auditlogUrl);

Review Comment:
   Awesome!
   
   I noticed that we also have C++ API using format string, e.g. 
`celix/BundleContext.h`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to