PengZheng commented on code in PR #477:
URL: https://github.com/apache/celix/pull/477#discussion_r1096495830


##########
.github/workflows/coverage.yml:
##########
@@ -24,18 +24,22 @@ jobs:
           CONAN_BUILD_OPTIONS: |
             -o celix:enable_testing=True
             -o celix:build_all=True
-            -o enable_code_coverage=True
+            -o celix:enable_code_coverage=True
+            -o celix:enable_testing_for_cxx14=True
+            -o celix:enable_testing_dependency_manager_for_cxx11=True
         run: |
           #force reequire libcurl 7.64.1, due to a sha256 verify issue in 
libcurl/7.87.0
-          conan install . celix/ci -pr:b default -pr:h default -if build 
${CONAN_BUILD_OPTIONS} -b missing --require-override=libcurl/7.64.1 
--require-override=openssl/1.1.1s
+          conan install . celix/ci -pr:b default -pr:h default -if build 
${CONAN_BUILD_OPTIONS} -b missing -b cpputest --require-override=libcurl/7.64.1 
--require-override=openssl/1.1.1s
       - name: Build
         run: |
           conan build . -bf build --configure
           conan build . -bf build --build
       - name: Test with coverage
         run: |
           cd build
+          source activate_run.sh

Review Comment:
   This fixes an issue introduced by #472, which was reproduced by 
https://github.com/apache/celix/actions/runs/4085503505/jobs/7043556947



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to