pnoltes commented on code in PR #476:
URL: https://github.com/apache/celix/pull/476#discussion_r1113433376
##########
bundles/http_admin/http_admin/src/activator.c:
##########
@@ -72,22 +85,22 @@ static int http_admin_start(http_admin_activator_t *act,
celix_bundle_context_t
act->useWebsockets = prop_use_websockets;
const char *svr_opts[] = {
- "document_root", root,
+ "document_root", httpRoot,
"listening_ports", prop_port,
"websocket_timeout_ms", prop_timeout,
- "websocket_root", root,
+ "websocket_root", httpRoot,
"num_threads", prop_num_threads,
NULL
};
//Try the 'LISTENING_PORT' property first, if failing continue with the
port range functionality
- act->httpManager = httpAdmin_create(ctx, root, svr_opts);
+ act->httpManager = httpAdmin_create(ctx, httpRoot, svr_opts);
for(long port = prop_port_min; act->httpManager == NULL && port <=
prop_port_max; port++) {
char *port_str;
asprintf(&port_str, "%li", port);
svr_opts[3] = port_str;
- act->httpManager = httpAdmin_create(ctx, root, svr_opts);
+ act->httpManager = httpAdmin_create(ctx, httpRoot, svr_opts);
Review Comment:
good find, but I indeed would like see this fixed in a separate PR. I
created an issue for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
