Troepje opened a new pull request, #494: URL: https://github.com/apache/celix/pull/494
In the websocket pubsub admin, effectively there was a busy loop with polling for new connections/subscribers AND for receiving data. In the TCP admin, the receiving data is handled in another thread, so the polling can be done on a lower frequency. In this pull request, I've removed the buffer mechanism. Note that if the callback takes long civetweb (and/or the tcp stack) is assumed to have enough buffers to cope with that. In practice, the behaviour is now the same as with the tcp admin. I've tested this at the project at work, the webpage of the webserver (web shell) is still responsive. No spinning threads are observed anymore, which was my goal. PS. note that this is my first PR on Celix, if I make a mistake in the etiquette, my apologies and please tell me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
