pnoltes commented on PR #537: URL: https://github.com/apache/celix/pull/537#issuecomment-1536194245
> Great job! Thanks to the hard working, our test coverage sets a new record. tada > > For large PR like this, I strongly suggest waiting for at least one LGTM before merging it. > > The deprecation of `utils_stringTrim` is worrysome. @pnoltes The lack of synchronization between shm client and server is also worth noting. Indeed great job and good to see a new coverage record :+1: Concerning the deprecation of `utils_stringTrim`. I deprecated that function purely because it does not have a `celix_` prefix. If we need a `celix_utils_trimInPlace` next to `celix_utils_trim` I see no issue with that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
