PengZheng commented on code in PR #546:
URL: https://github.com/apache/celix/pull/546#discussion_r1186779336
##########
libs/framework/src/service_tracker.c:
##########
@@ -539,12 +538,12 @@ static celix_status_t
serviceTracker_untrack(service_tracker_t* tracker, service
if (remove != NULL) {
serviceTracker_untrackTracked(tracker, remove, size, true);
Review Comment:
`remove` might be freed in `serviceTracker_untrackTracked`. Thus it's not
reliable to use its value, which might be reassigned to a new
`celix_tracked_entry_t` and be added to `untrackingServices` for a second time,
in `celix_arrayList_remove(tracker->untrackingServices, remove)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
