PengZheng commented on issue #503: URL: https://github.com/apache/celix/issues/503#issuecomment-1540160676
I see several issues with this prototype: 1. Weird semantics. Why trying to log a trace message will dump the err? 2. Inefficiency. Try `celix_err_popLastError` will allocation the err per-thread-storage, even if there is no user of err in this thread. 3. Reduced usefulness of stacked error message. The current implementation output err messages one by one, which will be interleaved by other log messages in multi-threaded application. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
