WopsS commented on code in PR #544: URL: https://github.com/apache/celix/pull/544#discussion_r1192668869
########## .clang-format: ########## @@ -0,0 +1,27 @@ +BasedOnStyle: LLVM +IndentWidth: 4 +AllowShortIfStatementsOnASingleLine: false +AlwaysBreakTemplateDeclarations: Yes +BinPackArguments: false +BinPackParameters: false +BreakBeforeBraces: Attach +ColumnLimit: 120 +ConstructorInitializerIndentWidth: 4 +Cpp11BracedListStyle: true +DerivePointerAlignment: false +IncludeBlocks: Regroup +KeepEmptyLinesAtTheStartOfBlocks: false +NamespaceIndentation: None +PointerAlignment: Right +ReflowComments: true +SortIncludes: false +SpaceAfterCStyleCast: false +SpaceBeforeAssignmentOperators: true +SpaceBeforeParens: ControlStatements +SpaceInEmptyParentheses: false +SpacesBeforeTrailingComments: 1 +SpacesInAngles: Never +SpacesInCStyleCastParentheses: false +SpacesInParentheses: false +SpacesInSquareBrackets: false +AlignEscapedNewlines: Right Review Comment: The following options are already set to the values here in clang-format 15: - BreakBeforeBraces - ConstructorInitializerIndentWidth - Cpp11BracedListStyle - NamespaceIndentation - ReflowComments - SpaceAfterCStyleCast - SpaceBeforeAssignmentOperators - SpaceBeforeParens - SpaceInEmptyParentheses - SpacesInAngles - SpacesInCStyleCastParentheses - SpacesInParentheses - SpacesInSquareBrackets - AlignEscapedNewlines Should they be specified here? I find it redundant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
