PengZheng commented on code in PR #560:
URL: https://github.com/apache/celix/pull/560#discussion_r1203306212
##########
libs/framework/src/dm_dependency_manager_impl.c:
##########
@@ -261,6 +265,11 @@ celix_array_list_t *
celix_dependencyManager_createInfos(celix_dependency_manage
static void celix_dm_allComponentsActiveCallback(void *handle, const
celix_bundle_t *bnd) {
bool *allActivePtr = handle;
+
+ if (celix_bundle_getState(bnd) != CELIX_BUNDLE_STATE_ACTIVE) {
+ return;
+ }
+
Review Comment:
I'm afraid this is not enough: nothing stops the bundle from stopping after
this check.
Note that `celix_framework_bundleEntry_getBundleEntryAndIncreaseUseCount`
does not protect bundle state from being changed. #557 is closely related.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
