xuzhenbao commented on PR #551:
URL: https://github.com/apache/celix/pull/551#issuecomment-1560412037

   > One thing I also would like to improve is the usage of service references 
and service registrations in the remote service admin interfaces.
   
   Hi @pnoltes 
   Can we remove `export_reference_t` and `import_reference_t` from 
`remote_service_admin_service_t`, and use `serviceProperties` instead of 
`serviceId` or add a new framework interface that can get service properties by 
`serviceId`, as follows:
   ~~~
   struct remote_service_admin_service_v2 {
        void *handle;
        celix_status_t (*exportService)(void *handle,  celix_properties_t 
*serviceProperties, celix_properties_t *additionalProperties, 
celix_array_list_pt *registrations);
        celix_status_t (*importService)(void *handle, endpoint_description_t 
*endpoint, import_registration_t **registration);
   
        celix_status_t 
(*exportRegistration_getEndpointDescription)(export_registration_t 
*registration, endpoint_description_t **endpoint);
   
        celix_status_t (*exportRegistration_close)(void *handle, 
export_registration_t *registration);
   
        celix_status_t (*importRegistration_close)(void *handle, 
import_registration_t *registration);
   };
   ~~~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to