pnoltes commented on code in PR #565:
URL: https://github.com/apache/celix/pull/565#discussion_r1213506302
##########
libs/dfi/src/dyn_type.c:
##########
@@ -731,7 +732,7 @@ void dynType_deepFree(dyn_type *type, void *loc, bool
alsoDeleteSelf) {
//nop
break;
default:
- LOG_ERROR("Unexpected switch case. cannot free dyn type %c\n",
type->descriptor);
+ celix_err_pushf("Unexpected switch case. cannot free dyn type
%c\n", type->descriptor);
Review Comment:
agree
##########
bundles/logging/log_helper/include/celix_log_helper.h:
##########
@@ -90,6 +90,14 @@ void celix_logHelper_logDetails(celix_log_helper_t*
logHelper,
int line,
const char *format, ...)
__attribute__((format(printf,6,7)));
+/**
+ * @brief Logs a message using the provided celix log level to the log_helper,
printf style.
+ * It will also print celix thread-specific storage error
messages(celix_err).
+ *
+ * Silently ignores log level CELIX_LOG_LEVEL_DISABLED.
+ */
+void celix_logHelper_logWithTssErrors(celix_log_helper_t* logHelper,
celix_log_level_e level, const char *format, ...)
__attribute__((format(printf,3,4)));
Review Comment:
Is it an idea to only add a
`celix_logHelper_logTssErrors(celix_log_helper_t* logHelper, celix_log_level_e
level)` function and a C++ `celix::LogHelper::logTssErrors(celix_log_level_e
level)`?
This requires an extra call for the users (using log helper to log a message
and then log celix err errors), but prevents that we (ideally) create an
alternative for the `log`, `vlog`, `logDetails` and `vlogDetails` in C and C++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
