PengZheng commented on code in PR #569:
URL: https://github.com/apache/celix/pull/569#discussion_r1231678932
##########
examples/celix-examples/track_tracker_example/src/activator.c:
##########
@@ -86,7 +86,7 @@ celix_status_t activator_start(activator_data_t* act,
celix_bundle_context_t *ct
act->svc.handle = act;
act->svc.calc = calc;
//note only triggers on calcTrk1, because of filter restrictions
- act->svcId = celix_bundleContext_registerService(ctx, &act->svc,
CALC_SERVICE_NAME, NULL);
+ act->svcId = celix_bundleContext_registerServiceAsync(ctx, &act->svc,
CALC_SERVICE_NAME, NULL);
Review Comment:
At first, I thought they were necessary to fix the deadlock in
`pubsub_topology_manager`.
Then I realized the real fix is to introduce
`celix_framework_useActiveBundles`.
They can be safely reverted without introducing deadlocks if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
