pnoltes commented on code in PR #589:
URL: https://github.com/apache/celix/pull/589#discussion_r1271551510
##########
CMakeLists.txt:
##########
@@ -196,6 +172,12 @@ include(CheckLinkerFlag)
check_linker_flag(CXX LINKER:--wrap,celix_nonexistent_symbol
LINKER_WRAP_SUPPORTED)
cmake_pop_check_state()
+# avoid unknown export "celix" error when building nothing
+add_library(celix INTERFACE)
+add_library(Celix::celix ALIAS celix)
+install(TARGETS celix EXPORT celix DESTINATION ${CMAKE_INSTALL_LIBDIR}
COMPONENT framework
Review Comment:
I assume this will generate a imported target?
##########
libs/pushstreams/CMakeLists.txt:
##########
@@ -16,10 +16,11 @@
# under the License.
set(PUSHSTREAMS_DEFAULT_ON ${CELIX_CXX17})
-celix_subproject(PUSHSTREAMS "Option to build the PushStreams library"
${PUSHSTREAMS_DEFAULT_ON} DEPS PROMISES)
+celix_subproject(PUSHSTREAMS "Option to build the PushStreams library"
${PUSHSTREAMS_DEFAULT_ON})
Review Comment:
Does this mean that the celix cmake function `celix_subproject` is no longer
used to configure dependecies, but this is now done using the Conanfile?
So for pushstream the lines :
```
if self.options.build_pushstreams:
self.options.build_promises = True
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
