pnoltes opened a new pull request, #594: URL: https://github.com/apache/celix/pull/594
This PR addresses an issue where changes to bundle zip files were not being copied to the "bundles" directory in the container. The process of copying updated bundles to a container "bundles" dir appears to have broken at some point. Unfortunately, I couldn't trace back the specific change that introduced this issue using git blame. Originally, the copying of bundles was tracked with a timestamp file, in combination with a CMake `add_custom_command`. However, attempts to resolve the problem with the add_custom_command proved unsuccessful, leading me to replace it with `add_custom_target`. In my opinion, a custom target is less than ideal, as a custom target dependency always triggers whenever a target is built. A comparison of the time to run `make -j` when nothing has changed demonstrated that on my systems, it took twice as long (albeit still under 1 second). An upside is that the current change seems to fix the usage CMake -> Ninja, which I previously had issues with. Building with `ninja`, compared to `make -j`, is significantly faster. In conclusion, despite its drawbacks, I believe this update is necessary for now to resolve the issue. Possibly in the future, we can revert to using add_custom_command instead of add_custom_target. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
