pnoltes commented on PR #588: URL: https://github.com/apache/celix/pull/588#issuecomment-1657223888
Added a `ENABLE_TESTING_ON_CI` cmake/conan option that is enabled when building on CI servers. The `ENABLE_TESTING_ON_CI` is used in the scheduled event and components_ready_check tests to increase to allowed timing error margin when running on a CI environment. Note that on my physical systems the error margin is a factor 10 stricter, but - based on the flaky test results - this is not possible on the virtual CI servers. And because the goal of the scheduled events is not to support very precise or high frequent scheduled events, IMO relaxing the timing requirements on the CI servers is acceptable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
