PengZheng commented on code in PR #627:
URL: https://github.com/apache/celix/pull/627#discussion_r1312714746
##########
misc/experimental/rust/CMakeLists.txt:
##########
@@ -26,13 +26,12 @@ if (CELIX_RUST_EXPERIMENTAL)
FetchContent_MakeAvailable(Corrosion)
Review Comment:
According to documentation, this method only work for CMake >= 3.19.
Our current requirement is `cmake_minimum_required (VERSION 3.18)`.
##########
misc/experimental/rust/CMakeLists.txt:
##########
@@ -26,13 +26,12 @@ if (CELIX_RUST_EXPERIMENTAL)
FetchContent_MakeAvailable(Corrosion)
Review Comment:
According to documentation, this method only works for CMake >= 3.19.
Our current requirement is `cmake_minimum_required (VERSION 3.18)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
