PengZheng commented on code in PR #627: URL: https://github.com/apache/celix/pull/627#discussion_r1327970443
########## misc/experimental/rust/celix/src/lib.rs: ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +extern crate celix_bindings; Review Comment: Given that it has already been specified in the manifest, I'm really confused why it was needed here? If the above line is removed, then it fails to build with unresolved import `rust_shell_api` error. However, removing `extern crate bindgen;` in build.rs will not cause any errors. I also found that it is claimed that "extern crate is no longer needed in 99% of circumstances"(https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
