pnoltes commented on code in PR #627: URL: https://github.com/apache/celix/pull/627#discussion_r1329162954
########## misc/experimental/rust/rust_shell_api/src/lib.rs: ########## @@ -0,0 +1,30 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +extern crate celix; + +use celix::Error; +pub const COMMAND_NAME: &str = "command.name"; +pub const COMMAND_USAGE: &str = "command.usage"; +pub const COMMAND_DESCRIPTION: &str = "command.description"; + +#[doc = "A trait to implement a Celix Shell Command"] +pub trait RustShellCommand { + fn execute_command(&self, command_line: &str) -> Result<(), Error>; Review Comment: This needs IMO some more experimenting and/or discussion. But a `&self` argument - so not mutable - in a (service) trait can be used to change a service state, but it requires the the implementing object uses a Mutex to change the state. An other option could be to register a services as Arc<Mutex<T>> or maybe require that a service template argument is `Sync`. But I think this is something to get more clear later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
