pnoltes commented on issue #659: URL: https://github.com/apache/celix/issues/659#issuecomment-1736054746
The ScheduledEventTestSuite tests scheduled events and are - as designed - time sensitive. I tried to allow enough error margin so that these test are not flaky, but evidently not enough. Note that for CI testing to error margen is much larger, because the build server are virtually machines (I assume): https://github.com/apache/celix/blob/master/libs/framework/gtest/src/ScheduledEventTestSuite.cc#L28-L34 ```C #if defined(__APPLE__) && defined(TESTING_ON_CI) const int ALLOWED_ERROR_MARGIN_IN_MS = 1500; #elif TESTING_ON_CI const int ALLOWED_ERROR_MARGIN_IN_MS = 1000; #else const int ALLOWED_ERROR_MARGIN_IN_MS = 100; #endif ``` I will look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
