On Sun, Oct 1, 2023 at 11:26 AM Pepijn Noltes <pepijnnol...@gmail.com> wrote: > > Adding my > +1 (binding) > And closing the vote. > > Thanks for voting. > > On Fri, Sep 29, 2023 at 7:55 PM Roy Lenferink <rlenfer...@apache.org> wrote: > > > > Just a minor detail which we should probably fix in the next release, > > but I noticed there is both a CHANGES.md and a RELEASE_NOTES > > in the root of the repository [1] [2] > > > > IMO the RELEASE_NOTES doesn't add much value to what is already > > described in the CHANGES.md so I suggest dropping that file to be as > > clear as possible for our users (the file hasn't been updated for > 4 > > years). > > > > If there is a reason to keep it, then the file should be updated. > > > > [1] https://github.com/apache/celix/blob/master/CHANGES.md > > [2] https://github.com/apache/celix/blob/master/RELEASE_NOTES > > > > Op wo 27 sep 2023 om 19:51 schreef Roy Lenferink <rlenfer...@apache.org>:
Good point and I will remove one of the files, in a post release PR. > > > > > +1 (binding) > > > > > > I verified: > > > * The SHA512 checksum > > > * The GPG signature > > > * Whether the package builds (it does) > > > * Whether all tests succeed (they do) > > > > > > Op wo 27 sep 2023 om 19:24 schreef Pepijn Noltes <pepijnnol...@gmail.com>: > > > > > >> This is the release vote for Apache Celix, version 2.4.0. > > >> > > >> It includes the following changes: > > >> > > >> https://github.com/apache/celix/tree/1fbd599c4a4141d147701e18377518f9fec8e338/CHANGES.md > > >> > > >> Source files: > > >> https://dist.apache.org/repos/dist/dev/celix/celix-2.4.0/ > > >> > > >> The commit ID to be voted upon: > > >> 1fbd599c4a4141d147701e18377518f9fec8e338 > > >> > > >> > > >> https://github.com/apache/celix/tree/1fbd599c4a4141d147701e18377518f9fec8e338 > > >> > > >> Celix's keys can be found at: > > >> https://dist.apache.org/repos/dist/release/celix/KEYS > > >> > > >> Information for voting on a release can be found at: > > >> https://www.apache.org/legal/release-policy.html#approving-a-release > > >> > > >> Please vote to approve this release: > > >> > > >> [ ] +1 Approve the release > > >> [ ] -1 Disapprove the release (please provide specific comments) > > >> > > >> Note that an Apache release needs to be a Majority Approval (requires > > >> at-least 3 binding +1 votes and more +1 votes than -1 votes). > > >> > > >> If this release is approved I will promote it to an official release > > >> (e.g. move from dist/dev to dist/release and tagging the release in git) > > >> > > >> This vote will be open for at least 72 hours. > > >> > > >
