pnoltes commented on PR #470:
URL: https://github.com/apache/celix/pull/470#issuecomment-1776990385
This PR is now ready for review.
As noted earlier this PR has breaking changes, so the PR was on hold until
Apache Celix 2.4.0 was released.
Some additional changes added based on the previous review comments:
- Updated celix_string/long_hash_map error handling, including a
`celix_status_t` return for the `put` functions. Note that before this change
the `put` functions returned the previous entry and now returns a status to
indicate whether the `put` was successful.
- Update properties `set` function to return a `celix_status_t` (this was
a `void`).
- Added error injection test to check the error handling of hash map put
and create, celix properties create, set, store and load.
- Added `equals` function for string/long hash map en properties
- Removed the deprecated iterator functions and macro.
There is still some work todo for storing, encoding any maybe arrays
handling for properties but IMO this PR is already big enough so I created a
separate issues for this: #674 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
