PengZheng commented on code in PR #470:
URL: https://github.com/apache/celix/pull/470#discussion_r1378679080
##########
libs/utils/gtest/CMakeLists.txt:
##########
@@ -43,7 +43,7 @@ celix_deprecated_utils_headers(test_utils)
configure_file(resources/properties.txt
${CMAKE_CURRENT_BINARY_DIR}/resources-test/properties.txt COPYONLY)
if (CELIX_CXX17)
- add_library(test_utils_cxx17tests STATIC
+ add_library(test_utils_cxx17tests OBJECT
Review Comment:
~~I have not figured out why static library does not work.~~
All unresolved symbols of the executable `test_utils` are satisfied by other
libraries, and it does not use any symbols in `test_utils_cxx17tests`.
Therefore, `test_utils_cxx17tests` is totally ignored.
Changing `test_utils_cxx17tests` to object library essentially makes it part
of `test_utils`.
##########
libs/utils/gtest/CMakeLists.txt:
##########
@@ -43,7 +43,7 @@ celix_deprecated_utils_headers(test_utils)
configure_file(resources/properties.txt
${CMAKE_CURRENT_BINARY_DIR}/resources-test/properties.txt COPYONLY)
if (CELIX_CXX17)
- add_library(test_utils_cxx17tests STATIC
+ add_library(test_utils_cxx17tests OBJECT
Review Comment:
~~I have not figured out why static library does not work.~~
All unresolved symbols of the executable `test_utils` are satisfied by other
libraries, and it does not use any symbols in `test_utils_cxx17tests`.
Therefore, `test_utils_cxx17tests` is totally ignored by linker.
Changing `test_utils_cxx17tests` to object library essentially makes it part
of `test_utils`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
