PengZheng commented on code in PR #691:
URL: https://github.com/apache/celix/pull/691#discussion_r1404110849
##########
libs/dfi/src/dyn_type.c:
##########
@@ -294,6 +296,14 @@ static int dynType_parseComplex(FILE *stream, dyn_type
*type) {
if (status == OK) {
TAILQ_FOREACH(entry, &type->complex.entriesHead, entries) {
count +=1;
+ struct complex_type_entry *entry2 = NULL;
Review Comment:
This is far from enough for runtime verification. If descriptors are
generated from service header, then we need not to worry about this, since the
compiler will check it for us. By the way, O(N^2) complexity is terrible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
