pnoltes commented on code in PR #711:
URL: https://github.com/apache/celix/pull/711#discussion_r1441745775
##########
libs/utils/src/hash_map_private.h:
##########
@@ -29,13 +29,17 @@
#include "hash_map.h"
-unsigned int hashMap_hashCode(const void* toHash);
-int hashMap_equals(const void* toCompare, const void* compare);
+#ifdef __cplusplus
+extern "C" {
+#endif
-void hashMap_resize(hash_map_pt map, int newCapacity);
-hash_map_entry_pt hashMap_removeEntryForKey(hash_map_pt map, const void* key);
-hash_map_entry_pt hashMap_removeMapping(hash_map_pt map, hash_map_entry_pt
entry);
-void hashMap_addEntry(hash_map_pt map, int hash, void* key, void* value, int
bucketIndex);
+CELIX_UTILS_DEPRECATED_EXPORT unsigned int hashMap_hashCode(const void*
toHash);
Review Comment:
The export macros are indeed not needed, removing them. Deprecated is
correct but IMO mainly valuable on a public api.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
