PengZheng commented on code in PR #699:
URL: https://github.com/apache/celix/pull/699#discussion_r1472339359
##########
libs/dfi/src/dyn_common.c:
##########
@@ -18,124 +18,92 @@
*/
#include "dyn_common.h"
+#include "celix_err.h"
+#include "celix_stdio_cleanup.h"
+#include "celix_stdlib_cleanup.h"
#include <stdlib.h>
#include <stdio.h>
#include <ctype.h>
#include <stdbool.h>
-#if CELIX_UTILS_NO_MEMSTREAM_AVAILABLE
-#include "open_memstream.h"
-#include "fmemopen.h"
-#endif
-
static const int OK = 0;
static const int ERROR = 1;
-DFI_SETUP_LOG(dynCommon)
-
-static bool dynCommon_charIn(int c, const char *acceptedChars);
-int dynCommon_parseName(FILE *stream, char **result) {
+int dynCommon_parseName(FILE* stream, char** result) {
Review Comment:
Totally agree!
I actually resisted the temptation of a uniform error code in this PR and
instead focused on understanding libdfi.
It will be done in another PR, before descriptor generation happens (#724).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@celix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
